Skip to content

Fix error on user deletion with reply #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Fix error on user deletion with reply #6555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions kitsune/questions/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,20 +704,15 @@ def is_taken(self):
"""
Convenience method to check that a question is taken.

Additionally, if ``self.taken_until`` is in the past, this will reset
the database fields to expire the setting.
If the question is no longer validly taken (due to missing user or expired time),
this will reset the database fields and return False.
"""
if self.taken_by is None:
assert self.taken_until is None
return False
if self.taken_by is None or self.taken_until is None or self.taken_until < datetime.now():

assert self.taken_until is not None
if self.taken_until < datetime.now():
self.taken_by = None
self.taken_until = None
self.save()
return False

return True

def take(self, user, force=False):
Expand Down